Closed gmaze closed 2 months ago
Hi folks, @catsch @Sauzede @grgdll @HCBScienceProducts,
Could I have some advice with regard to how can I easily identify all variables related to Radiometry in the Erddap list of variables below (the BGC dataset filling the Erddap is from synthetic profiles).
I would need this in order to filter out radiometry variables not in R data mode for the "Standard user mode", following recommendation in this issue https://github.com/euroargodev/argopy/issues/280#issuecomment-1617498660
All variables that contain "up_radiance", "downwelling_par" or "down_irradiance" are radiometry-related. "up_radiance" and "down_irradiance" are followed by 3 numerical digits that give the associated wavelength in nm, if you want to refine your filter.
awesome ! thanks @HCBScienceProducts !
one more question @catsch @Sauzede @grgdll @HCBScienceProducts :
what about CDOM ? it's all in real time data mode, so how can we consider it in "standard" user mode ?
We are presently waiting for new calibration factors for CDOM or a list of QC=4 from Seabird so presently, it should not be used at all, more to come at the next ADMT...
so presently, it should not be used at all,
thanks @catsch !
do you think we can keep Radiometry in the 'research' user mode ?
Most of the time, Radiometry is good data (in R mode)
and Radiometry exists in D and (1,2,5,8) is Ok
Do I answer the question ?
do you think we can keep Radiometry in the 'research' user mode ?
Yes to radiometry both in 'research' mode with selection like all other variables (only D-mode, QC flags '1', '5', or '8').
On radiometry in 'standard' mode @.***): Should this rather be R-mode or A-mode or D-mode with QC flags '1', '2', '5', or '8' (instead of R-mode only). I know there's been some DMQC on radiometry done, i.e., D-mode exist (and are better data than the R-mode data).
On CDOM: No separate treatment on the argopy side should be needed for the 'standard' mode but can be treated like all other variables (no R-mode but only A-mode or D-mode, QC flags '1', '2', '5', or '8'). The CDOM issues are to be resolved on the Argo data management side. Once solved, it may eventually transition from today's "only R-mode and better not be used" towards A-mode or D-mode and can then appear just like any other variable. Same for the 'research mode': No separate treatment of CDOM (or radiometry) needed.
Place holder for work kicked off during 2024 LOV visit. Closes #361 Adressed #363
What's in this PR:
transform_data_mode
, that is doing what was doing thefilter_data_mode
method before, but this method was very badly named: merge PARAM with PARAM_ADJUSTED according to DATA_MODE valuesfilter_data_mode
is now really doing what is was supposed to do: filter points according to data mode valuespostprocessing
method in the data fetcher facade, so that it clearly implement user mode requirements for 'phy' and 'bgc' datasetauxiliary
index in the`etc
GDAC folderPoke @Sauzede and @catsch
Breaking changes in the API:
history
is replaced byProcessing_history
filter_data_mode
filter_data_mode
astransform_data_mode