euroargodev / argopy

A python library for Argo data beginners and experts
https://argopy.readthedocs.io
European Union Public License 1.2
186 stars 41 forks source link

Eco-CI v4.0-rc3 #367

Closed ArneTR closed 4 months ago

ArneTR commented 5 months ago

Hey @gmaze ,

we have massively slimmed our Eco-CI tool and wanted to bring you the lastest update via PR.

What I changed in your workflow

Also we have done some improvements to the SCI calculation and are now showing more granular data.

In essence though the speed gain should be the biggest win. We went down from ~30 seconds to ~1-2 seconds of overhead for a typical 5-7 step workflow.

PR-Comments

I was not sure if you did not want the integration for PR-Comments or just did not know about it, but I added it as example to this PR. What it does is that it will show you the details of a workflow energy and cabon cost in the PR as comment. See screenshot attached. Please remove if you had that not activated explicitely

Screenshot 2024-06-18 at 3 17 42 PM

Using this feature requires "permissions -> pull_request -> write" to be set, which allows Eco-CI to write a comment in the PR. If you have second thoughts about the permissions you can find details here what it entails: https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28#repository-permissions-for-pull-requests

Hope you like the updated Eco-CI and happy for your feedback!!

gmaze commented 5 months ago

Hi @ArneTR Thanks a lot for the update, this looks great !

About the PR: Yes I noticed this before, but I'm happy with the G-Actions summary print already (eg)

Just 1 question: About the machine-uuid, I understand I can set this on a secret, but then it will be the same whatever the machine the G-Action is running on, is it expected ? what is the actual real use from Eco-CI of the machine-uuid ?

ArneTR commented 4 months ago

ty for the notes. I updated the PR

ArneTR commented 4 months ago

Also just a heads up on a new update we have done in the dashboard. I believe this might be interesting for you :)

https://github.com/green-coding-solutions/green-metrics-tool/pull/823