eurodatacube / eodash-catalog

MIT License
1 stars 0 forks source link

YAML batch_2 update #101

Closed FedericoRondoni closed 5 months ago

FedericoRondoni commented 6 months ago

E10a1_agricultural_production_productive_area E10a2_agricultural_production_area E10a3_agricultural_production_area_change E10a10_harvesting_evolution E10a5_fruit_production E10a6_harvested_parcels_evolution E10a8_winter_cereals E10a9_agricultural_workers E11_shopping_center_activity

FedericoRondoni commented 6 months ago

Hi @santilland could you check why there is the error on the checks? I cannot find the reason why it fails during the built of the E10a10 indicator. Thanks!

santilland commented 6 months ago

Strange, locally it seems to run fine, might be a connection issue to one of the services, i will try to rerun

santilland commented 6 months ago

seems to throw always the same error, searching a bit for potential issues i found: Windows style newline characters can cause issues in Cygwin I will try to check the new line format in the file

santilland commented 6 months ago

@FedericoRondoni could you push another small change? Is it possible you had a line break in the pull request first comment before? If yes, maybe your edit fixed it, if not, i can't really think of why it is not working. The build works fine locally.

FedericoRondoni commented 6 months ago

@santilland yes, it might be that. How can we solve it?

lubojr commented 6 months ago

@FedericoRondoni I'm afraid that after you've edited the PR comment, you need to push a new commit (with some, even tiny changes) to trigger the automatic workflow with the new PR comment applied.

For us rerunning a past workflow would take the PR comment in the original form in the past.

FedericoRondoni commented 6 months ago

Hi @santilland and @lubojr now it worked 😊 Thanks!

FedericoRondoni commented 6 months ago

@dmoglioni

santilland commented 5 months ago

Here is also the link to see it in the client: https://eodash-testing.eox.at/ui-panels-cat/?catalog=YAML-batch_2 (Still to be done, the collapsible header will be removed for entries with only one item)

FedericoRondoni commented 5 months ago

@FedericoRondoni please address the comments in the yamls

I think I have done it. I'm not sure I know how to handle a change request in GitHub, but the files should be good now