eurodatacube / eodash-catalog

MIT License
1 stars 0 forks source link

Update yaml files #84

Closed FedericoRondoni closed 7 months ago

FedericoRondoni commented 9 months ago

CAQ_ports_air_quality E13o_vessel_density_all E13p_vessel_density_cargo E13q_vessel_density_tanker E13r_vessel_density_others C3S_meteorological_variables

FedericoRondoni commented 8 months ago

Hi @santilland @lubojr I don't know if I'm doing something wrong. I tried to modify the YAML files directly from here as we agreed, but I see that "all checks have failed". I don't know what these checks are. Please tell me if I have to do something different :)

santilland commented 8 months ago

Hello @FedericoRondoni , we changed the automatic generation and deployment of the catalog for branches, it now possible to specify which collections one wants to test, instead of always generating all collections. As we need to adapt the catalog generation anyhow once we have some examples the checks are currently not important. For test branches it expects to have information on which collections should be tested, i will change the default behavior for now

FedericoRondoni commented 8 months ago

Hi @santilland and thanks for your reply. How can I do that?

santilland commented 8 months ago

You can write the list of collection identifiers (separated by spaces) you want to test in the body of the pull request. So by editing the first "comment" of the pull request. After you push a commit it should then only generate the collections provided in that list.

FedericoRondoni commented 8 months ago

Like this? Sorry for these questions, but I'm not an expert GitHub user

santilland commented 8 months ago

No problem, it is not common use what we are doing here, so questions are very much welcome, we will need to better describe and document the process we are still evaluating. The collection identifier for generation is the file name (without the extension), so in this case it would be:

C1_ports_shipping_aq CDS3_wind_10m_u

FedericoRondoni commented 8 months ago

Ah ok! Clear Thanks Daniel

santilland commented 8 months ago

Looks good, this should apply for your next commit then

santilland commented 8 months ago

@FedericoRondoni please make sure that the license field uses a spdx license identifier as defined here: https://spdx.org/licenses/

FedericoRondoni commented 8 months ago

@FedericoRondoni please make sure that the license field uses a spdx license identifier as defined here: https://spdx.org/licenses/

Hi Daniel, I checked already, but I couldn't find any relevant license. I will check again. However, is there a procedure to bypass this issue if one license is not present in the spdx catalogue?

santilland commented 8 months ago

If i understand the STAC definition, the value can also be various or proprietary. We could set the license to proprietary and then add the license definition as asset if it exists online somewhere or we save it in the assets repository

FedericoRondoni commented 8 months ago

Hi @santilland, I also added the license field to two yaml files here, but maybe there is something that you need to implement in this branch as well?

santilland commented 8 months ago

Yes, we will need to merge the updates from the other branch to this one, i can do it once we merge the other branch

FedericoRondoni commented 8 months ago

Yes, we will need to merge the updates from the other branch to this one, i can do it once we merge the other branch

Ok perfect!

santilland commented 8 months ago

All right, changes integrated, automatic build is passing now again

FedericoRondoni commented 8 months ago

Hi guys @santilland @lubojr once the merging of the assets branch YAML-alignment is done, we can ask Anca to review these YAMLs and descriptions. We will continue to prepare the other batches.

santilland commented 8 months ago

@aapopescu this pull request is the first batch ready to be merged, you can see the preview of the catalog with following url: https://eodash-testing.eox.at/ui-panels-cat-stacinfo/?catalog=yaml_test

santilland commented 7 months ago

@FedericoRondoni @aapopescu the new stac structure was introduced and merged into this branch, we also merged the test branch of the client, so you can explore the client with the current data here: https://eodash-testing.eox.at/ui-panels-cat/?catalog=yaml_test I will write an extra mail with information on "grouping".

lubojr commented 7 months ago

@FedericoRondoni Please whenever there are renamings of the name of YAML files, these changes need to be reflected in the corresponding catalog YAML, otherwise the build fails. I will take care of fixing this in the already merged PRs batch_3, batch_4 and batch_5 but could you please address the issues in this PR? For example collections/C2_ports_cars_aq.yaml -> collections/C2_ports_people_aq.yaml has to be changed in https://github.com/eurodatacube/eodash-catalog/blob/main/catalogs/race.yaml