search

eurofurence / crittersystem

Shift planning system for Eurofurence on-site departments forked from the Engelsystem which powers Chaos events.
https://critter.eurofurence.org
GNU General Public License v2.0
8 stars 1 forks source link

Create Location shows an error if no Telegram handle was set #9

Closed Corborax closed 2 months ago

Corborax commented 2 months ago

User Role

Critter System Staff

System Type

Other

Operating System

Other

OS Version

-

Browser Details (if applicable)

-

Steps to Reproduce

Create a new location leave telegram empty

Expected Behavior

A new location will be created.

Actual Behavior

A Telegram account is expected for a location

Feature Area

Other

If you selected "Other", please specify

Location Management

Severity

Critical Problem

Error Messages

No response

Workarounds Tried

No response

Network Type

None

Anything Else?

Remove the telegram field from location. There is no need for a Telegram contact for a room / location.

Corborax commented 2 months ago

grafik

Results in

grafik

Corborax commented 2 months ago

LocationFactory.php checks at Line 21 for dect https://github.com/eurofurence/crittersystem/blob/0e0329f20aff64a6e83f49ecab6313e3b34e20f1/db/factories/LocationFactory.php#L21

Corborax commented 2 months ago

class Location extends BaseModel

https://github.com/eurofurence/crittersystem/blob/0e0329f20aff64a6e83f49ecab6313e3b34e20f1/src/Models/Location.php#L49 https://github.com/eurofurence/crittersystem/blob/0e0329f20aff64a6e83f49ecab6313e3b34e20f1/src/Models/Location.php#L55

Fenrikur commented 2 months ago

Might have been due to passing null to ltrim() in LocationsController.php. If that was indeed the issue, it should be fixed by https://github.com/eurofurence/crittersystem/commit/cd471d0d62cd8c56d2b571c4cec35561d8a26151.

Corborax commented 2 months ago

Should be resolved with the previous commit.