europarl / dcat-ep

The DCAT-AP profile of the European Parliament.
https://europarl.github.io/dcat-ep
1 stars 1 forks source link

Inconsistent definition of dcat:theme for dcat:DataService and dcat:Dataset #20

Closed andrea-perego closed 6 days ago

andrea-perego commented 1 year ago

The property shapes for dcat:theme are currently defined as follows:

For dcat:DataService:

https://github.com/europarl/dcat-ep/blob/2f920e96f60a3c0fcc3207f2c5eec472dcb90cc4/0.3/dcat-ep.shacl.ttl#L855-L862

https://github.com/europarl/dcat-ep/blob/2f920e96f60a3c0fcc3207f2c5eec472dcb90cc4/0.3/dcat-ep.shacl.ttl#L864-L876

For dcat:Dataset / dcat:DatasetSeries:

https://github.com/europarl/dcat-ep/blob/2f920e96f60a3c0fcc3207f2c5eec472dcb90cc4/0.3/dcat-ep.shacl.ttl#L1028-L1036

The property shape for dcat:Dataset / dcat:DatasetSeries is missing the sh:node constraint, and should be aligned with the one for dcat:DataService.

Moreover, the sh:node constraint for dcat:DataService specifies the wrong class, because of a typo - i.e., euvoc:DataTheme instead of euvoc:DatasetTheme:

https://github.com/europarl/dcat-ep/blob/2f920e96f60a3c0fcc3207f2c5eec472dcb90cc4/0.3/dcat-ep.shacl.ttl#L872

andrea-perego commented 8 months ago

This issue is being fixed in the DCAT-EP editor's draft - see PR https://github.com/europarl/dcat-ep/pull/28