european-commission-empl / European-Learning-Model

Data Model for the Europass Digital Credentials Infrastructure
European Union Public License 1.2
49 stars 22 forks source link

[EDC Constraints shacl] update - remove fields that may cause loops #56

Closed rdolcetr closed 1 year ago

rdolcetr commented 2 years ago

Update EDC-constraints.ttl file; Some fields may cause a loop if informed. This fields should be removed from the DM:

Update JSON-LD file if necessary

NatasaSofou commented 2 years ago

It was agreed to include inverse properties in the ontology. Shall we remove them from edc-ap shacl or from the ontology as well?

jan-forster-cognizone commented 2 years ago

Many parts of the model can result in loops (not only these direct ones, but also loops of several steps). General practice is to solve this on an application level when flattening the graph for specific purposes.

Esayos commented 2 years ago

Hi everyone,

As the ontology is not longer being used at the AP validation process, is this now possible? We do check for loops (including several steps loops) at application level before creating the JSON files but constraint edc:AwardingProcess-elm_awards mincount 1 is forcing us to create a loop (Claim->AwardedBy->Awards->Claim) that we would rather avoid. If removing bidirectional relations is not possible, could alternatively remove this constraint?

NatasaSofou commented 1 year ago

Proposed solution: Remove inverse properties from EDC-ap, but keep them in the ontology.

jan-forster-cognizone commented 1 year ago

Hi, was this cleared with @anthonycamilleri? In the past, we agreed to keep the inverses. We could remove them as Natasa suggests, but it would not be an advisable approach from the modelling point of view.

rdolcetr commented 1 year ago

Closing this issue. Instead of removing the fields, we'll be making them optional. New ticket opened for this: #70