search

european-commission-empl / european-digital-credentials

European Union Public License 1.2
5 stars 3 forks source link

EDCI Commons does not compile because of non-existing dependency Gson-extras #2

Open SeSodesa opened 3 years ago

SeSodesa commented 3 years ago

Like the title implies, Google does not maintain their Gson-extras package on Maven central, but it is still included as a dependency in

edci-commons/pom.xml .

This prevents the compilation edci-commons and therefore the rest of the sub-packages (or whatever the heck these are called in the Java world) in this repository.

Danilo Pianini actively maintains a fork of the Google Gson extras at the address https://github.com/DanySK/gson-extras, and on Maven central at https://search.maven.org/artifact/org.danilopianini/gson-extras. Replacing

<dependency>
    <groupId>com.google.code.gson</groupId>
    <artifactId>gson-extras</artifactId>
    <version>${org.gson.version}</version>
</dependency>

with

<dependency>
    <groupId>org.danilopianini</groupId>
    <artifactId>gson-extras</artifactId>
    <version>0.2.2-dev1n+f8657bfc</version>
</dependency>

in

edci-commons/pom.xml

allows edci-commons to compile again. I would make a pull request, but forking of this repository is disallowed.

Esayos commented 2 years ago

Hi @SeSodesa, we have found in fact some dependencies that require an update to the repository were they are found. For next version, we will include a new maven settings file which should include all of the required repositories.

In the meantinme, you can add https://artifactory.cronapp.io/public-release/ repository to your maven settings, which is the one that will be used in future releases.