european-modelling-hubs / covid19-scenario-hub-europe

European Covid-19 Scenario Hub.
https://covid19scenariohub.eu/
Other
5 stars 17 forks source link

Checks for scenario hub #2

Open kathsherratt opened 2 years ago

kathsherratt commented 2 years ago

We may need to edit some of the validations to accept scenario hub submissions.

For now I can think of:

Bisaloo commented 2 years ago

Most of this is already implemented in the schema files:

I want to try to do a test submission this week but I have been too busy until now.

kathsherratt commented 2 years ago

Great that this is mostly implemented!

I was wondering if it would help to have for each round to have a round-specific metadata or config type file that could be used for these validations.

This would include checks that need to happen for each forecast file but are round specific. For instance, the scenario IDs, accepted start/end dates for projections, and the number of weeks allowed should all be checked against a pre-specified list of valid values, but these values can/will each change for each round. I guess we wouldn't want to have to edit a basic schema files each time for these.

I am not sure how difficult it would be to add this functionality to the package, and there could be a better way of doing this - what do you think?

Bisaloo commented 2 years ago

Since the schema files are located in the repo (covid19-forecast-hub-europe/covid19-scenario-hub-europe in this case), I believe it's fine to edit the relevant lines in the schema files each time.

If we go this route, then no change in required in the ForecastHubValidations package.