search

europeana / media-player

Media player developed under the Europeana Media Generic Services Project
European Union Public License 1.2
13 stars 1 forks source link

Correctly deal with multiple canvas elements in a manifest #87

Closed pietervanleeuwen closed 4 years ago

pietervanleeuwen commented 4 years ago

Also added method and init param to request a specific canvas element

pietervanleeuwen commented 4 years ago

The line $('.time-display').after($('.volume')); has been removed because this caused issues with multiple canvas elements containing for every canvas a control element (so 2 canvas elements give 2 control bars, for each canvas one, with both two volumes after it due to the mentioned code).

Instead the order of the volume and fullscreen has been changed in the iiif-av-components fork we use (that also includes extras like fullscreen button, error handling, etc)

Please do npm install or npm remove @iiif/iiif-av-component and then add it back again _npm install --savedev Noterik/iiif-av-component#build2 then it should look properly like here in the test

Schermafbeelding 2020-05-25 om 12 34 16