improve legend box dimension computation

eurostat / eurostat-map.js

Reusable library to quickly create and customise web maps showing Eurostat data directly retrieved from Eurostat database.

https://github.com/eurostat/eurostat-map.js

Other

60 stars 4 forks source link

improve legend box dimension computation #39

Closed jgaffuri closed 3 years ago

jgaffuri commented 3 years ago

See the 'TODOs' in legend.js file. Use SVG getBBox to compute automatically the dimensions of the legend in the end, and apply this dimension to the legend box. Then, get rid of 'computeWidth' and 'computeHeight' methods. It would then no longer be necessary to indicate the legend width/height in their config. See:

https://developer.mozilla.org/en-US/docs/Web/API/SVGGraphicsElement/getBBox
d3.select("#usefulSelector").node().getBBox();

jgaffuri commented 3 years ago

Done.