Apologies if any of my changes were out-of-line (like changing the version which likely should be done by yourself or submitting the .alfredworkflow), but since there’s no CONTRIBUTING.md, I’m not sure how you prefer contributions. I tried following your style.
Naturally, if you want only part of the changes, tell me which and I’ll make the modifications.
This change:
Changes the version to 1.75 (including current-version.json and updates.json).
Updates the description to Check who is Streaming on twitch.tv and watch your favorite Stream via LiveStreamer on VLC or mpv. (includes mpv).
Changes execution from a Terminal to a Run Script. There’s no sense in calling a terminal and leaving it open, and using nohup and &. If we add a sensible PATH to the top of that script, it’s likely it’ll be found. If a user needs a more complex PATH, it’s sensible to ask them to add it to the script. It’s better to have a slightly worse experience for a small percentage of people than a worse experience to everyone (by opening an extra terminal).
Adds OneUpdater (forum post). It’s already completely set up, so you don’t need to touch it ever again, and it’ll simply work. With it, the only thing you need to do is update your workflow as usual. OneUpdater (the pink node, which is completely self-contained) will check for updates automatically every 15 days and download and open new versions to users when they are available. I know you already have AlleyOop/Monkey Patch support, but those systems are largely unused today and require users to use an external workflow. This system works internally, with no need for user (or yours) intervetion.
Here’s how it looks now:
and the Run Script:
PATH="/usr/local/bin:$PATH"
if [ `which livestreamer` ]; then
livestreamer --http-header Client-ID=pq1763hfd37807lw0z8pqum3isqr4hd {query} high
elif [ `which mpv` ]; then
mpv {query}
fi
Apologies if any of my changes were out-of-line (like changing the version which likely should be done by yourself or submitting the
.alfredworkflow), but since there’s no CONTRIBUTING.md, I’m not sure how you prefer contributions. I tried following your style.Naturally, if you want only part of the changes, tell me which and I’ll make the modifications.
This change:
1.75(includingcurrent-version.jsonandupdates.json).Check who is Streaming on twitch.tv and watch your favorite Stream via LiveStreamer on VLC or mpv.(includesmpv).Terminalto aRun Script. There’s no sense in calling a terminal and leaving it open, and usingnohupand&. If we add a sensiblePATHto the top of that script, it’s likely it’ll be found. If a user needs a more complexPATH, it’s sensible to ask them to add it to the script. It’s better to have a slightly worse experience for a small percentage of people than a worse experience to everyone (by opening an extra terminal).OneUpdater(forum post). It’s already completely set up, so you don’t need to touch it ever again, and it’ll simply work. With it, the only thing you need to do is update your workflow as usual.OneUpdater(the pink node, which is completely self-contained) will check for updates automatically every 15 days and download and open new versions to users when they are available. I know you already have AlleyOop/Monkey Patch support, but those systems are largely unused today and require users to use an external workflow. This system works internally, with no need for user (or yours) intervetion.Here’s how it looks now:
and the
Run Script: