euslisp / jskeus

This repository contains EusLisp software developed and used by JSK at The University of Tokyo
23 stars 55 forks source link

more documentation for pointcloud functions #255

Open k-okada opened 9 years ago

k-okada commented 9 years ago

@YoheiKakiuchi What's the difference between make-msg-from-3dpointcoud and make-eus-pointcoud-from-ros-msg ?

make-eus-pointcloud-from-ros-msg1 is sensor_msgs::PointCloud version of make-eus-pointcloud-from-ros-msg (which takes sensor_msgs::PointCloud2 ?) if so why make-eus-pointcloud-from-ros-msg1 does not have rgb, binary, scale keyword arguments?

$ grep pointcl *| grep def -A 1
roseus-utils.l:(defun make-msg-from-3dpointcloud (points-list &key color-list (frame "/sensor_frame"))
roseus-utils.l:(defun make-eus-pointcloud-from-ros-msg1 (sensor_msgs_pointcloud)
roseus-utils.l:  (let* ((pts (send sensor_msgs_pointcloud :points))
--
roseus-utils.l:(defun make-ros-msg-from-eus-pointcloud (pcloud &key (with-color :rgb)
roseus-utils.l:  "Convert from pointcloud in eus to sensor_msgs::PointCloud2 in ros"
--
roseus-utils.l:(defun make-eus-pointcloud-from-ros-msg (msg &key (pcloud) (remove-nan))
roseus-utils.l:  "Convert from sensor_msgs::PointCloud2 in ros to pointcloud in eus"
YoheiKakiuchi commented 9 years ago

make-eus-pointcloud-from-ros-msg1 is sensor_msgs::PointCloud version of make-eus-pointcloud-from-ros-msg And make-eus-pointcloud-from-ros-msg takes sensor_msgs::PointCloud2 Now, almost all user use PointCloud2. make-msg-from-3dpointcloud is a converter from list of points(3D vector) to sensor_msgs::PointCloud