search

eutro / MultiblockTweaker

Add GregTech CE Multiblocks via CraftTweaker
GNU Lesser General Public License v3.0
8 stars 11 forks source link

[Bug] Multiblock Tweaker used with GTCE 1.15 causes JEI to fail at loading machine recipes and multiblock patterns #14

Closed BraggestSage833 closed 3 years ago

BraggestSage833 commented 3 years ago

Mod used: GTCE1.15 JEI 4.1.20.586 Multiblock Tweaker 1.3.2

New world created: yes

Issue: As mentioned on discord GTCE 1.15 introduced #1580. If Multiblock Tweaker is used to make a recipe map (and/or) multiblock pattern with GTCE 1.15, no multiblock patterns show up in jei other than Multiblock Tweaker's. This also causes all machines to lose their jei recipe map pages. I have included an image of the JEI multiblock pattern screen and the script used 2021-05-20_12 29 19

Exaxxion commented 3 years ago

@ALongStringOfNumbers and I are looking into this and it seems that while most of the property methods were deprecated and routed to the new implementation automatically, the property key set accessor method was not one of them. Since the method it's trying to call no longer exists, the mod is breaking at runtime.

It should be pretty simple to patch this by fixing the few places where now-nonexistent methods are called, but in the longer term the deprecated functions should also be replaced with the new Recipe Property storage methods.

serenibyss commented 3 years ago

I can confirm that the fix suggested will work, that is all it took for me to do similarly in Gregicality