search

euvl / vue-js-modal

Easy to use, highly customizable Vue.js modal library.
http://vue-js-modal.yev.io
MIT License
4.35k stars 592 forks source link

possible memory leak issue after closing #404

Closed dithidi closed 5 years ago

dithidi commented 5 years ago

Problem:

I am using vue-js-modal dynamically and am relying on the clickToClose functionality to close the modal when clicking the background. I noticed some potential memory leak issues but I'm no expert in these things.

I ran a performance profile of my SPA. After pressing record I clicked collect garbage to serve as a baseline. Then I opened and closed the modal 5 times in a row and then sat stationary for a few seconds after the final modal close before ending the recording. I am attaching the HEAP graph below. Is anyone else seeing this or am I missing something that manually needs to be done?

Example & screenshots:

screen shot 2019-02-13 at 9 15 19 am
dithidi commented 5 years ago

I just tested this again and the memory usage seems fine this time. I'm going to close this out for now unless I see it again.