search

euvl / vue-js-modal

Easy to use, highly customizable Vue.js modal library.
http://vue-js-modal.yev.io
MIT License
4.35k stars 592 forks source link

Replace parseInt by Math.floor to avoid issues with floating-point re… #725

Open utlime opened 3 years ago

utlime commented 3 years ago

…presentation of number

Issue: parseInt(2.222e-4) === 2, because it is equal to parseInt('2.222e-4') or parseInt(2.222e-4.toString())

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

utlime commented 3 years ago

Hi @euvl , which branch I can use for version 1, because master has version 2.

euvl commented 2 years ago

Do you mean vue 1?

utlime commented 2 years ago

Hi @euvl , no, I mean version 1 for this package. Not sure if that issue is reproduced for version 2 or not.

Currently I'm using my fork, but it would be good to apply this fix and release patch for version 1 =)

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.