vue-js-modal test code issue from 2.0.0

euvl / vue-js-modal

Easy to use, highly customizable Vue.js modal library.

http://vue-js-modal.yev.io

MIT License

4.35k stars 592 forks source link

vue-js-modal test code issue from 2.0.0 #739

Open mercedesbenz00 opened 2 years ago

mercedesbenz00 commented 2 years ago

Problem:

Cannot do unit test for vue-js-modal from 2.0.0. Because in https://github.com/euvl/vue-js-modal/blob/master/src/PluginCore.js, show/hide function is defined as const. So we can not mock for unit test.

I think there is no way to test in this case, maybe need to remove const for show/hide function. Thanks.

Version:

v2.0.1

Example & screenshots:

I have checked stackoverflow for solutions and 100% sure that this issue is not not related to my code.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.