search

euvl / vue-js-toggle-button

:fish_cake: Vue.js 2 toggle / switch button - simple, pretty, customizable
http://vue-js-toggle-button.yev.io/
MIT License
934 stars 133 forks source link

Request: Remove scoped attribute on <style> #118

Closed rebz closed 5 years ago

rebz commented 5 years ago

Thanks for the plugin, was easy to toss into a project.

What's the reasoning behind using scoped styles?

Requesting that the scoped attribute be removed. Having it makes overriding styles far more difficult than need be. Most NPM components I use do not scope their styles as they choose unique style names to ensure other packages do not conflict.

Having to wait till a scoped data attribute value is generated to define a class override is bad practice.

rebz commented 5 years ago

Alternatively, you could have the inline style block be exported to external CSS and Scss files when building. Doing so would allow developers greater ease of customization.

rebz commented 5 years ago

Kept running into issues styling, then an issue where the component would accept the proper default value of false (using v-model) but styled as if the value were true. Ended up ripping out the package and rolled my own. Definitely one of the cleaner Vue Toggle components out there, but for customization it is a burden.