search

euxhenh / cellar

Interactive software tool for the assignment of cell types in single-cell studies.
https://cellar.cmu.hubmapconsortium.org/app/cellar
MIT License
31 stars 5 forks source link

Coloring by an arbitrary cell metadata column (enhancement) #9

Open VPetukhov opened 1 year ago

VPetukhov commented 1 year ago

To my understanding, currently there is no way to color the dataset by anything but cluster id. Having a color column selector would add a lot to usability. For example, adding a drop-down to the left of "Change Color Palette". Seems like a very easy fix. Do you plan adding such functionality? If it would help, I can submit a PR for that.

euxhenh commented 1 year ago

I agree that this would be useful. Were you thinking of allowing all keys in adata.obs to be selected? How would we handle columns with too many categorical values? From my experience, this can slow down plot generation a lot.

VPetukhov commented 1 year ago

Thank you for the quick reply! Yes, I meant all variables from adata.obs. IMO, it's fine to leave on the user-side: if they're willing to wait, that's alright. But if you prefer, a hard limit of 30-50 values can be used.

euxhenh commented 1 year ago

Sounds good! I will work on this. Adding it to the plot's header sounds right.

VPetukhov commented 1 year ago

Thank you so much!