ev-map / EVMap

Android app to find electric vehicle charging stations - compatible with community databases such as GoingElectric.de and OpenChargeMap.org.
https://ev-map.app/
MIT License
190 stars 52 forks source link

"Material You" dynamic colors #288

Open johan12345 opened 1 year ago

johan12345 commented 1 year ago

Not sure how well this works for EVMap, I've not seen many 3rd party apps that implement this feature yet. https://github.com/material-components/material-components-android/blob/master/docs/theming/Color.md#using-dynamic-colors

holdit commented 1 year ago

At least 5 of the apps I use already support it. They mostly change the accent and secondary colours of headers/titles, buttons, toggles, and sometimes icons. I'm neutral about this.

On some apps, it makes apps look more "integrated" with the system. For example, the file manager I use almost looks like Android menus as it now uses the same colours. On others, I think it makes apps lose their "branding", so I'm not sure if all apps will implement this. Companies especially... I doubt PayPal, Amazon, banks, etc, want their app to be pink or something like that.

For EVMap, I wouldn't mind, but I guess you as developer would have to be okay with it losing the green tones. You could still use some of the green colors, but then it might be look like a "frankenstein" app if colors don't mix well. I guess it's one of those features that shouldn't be half implemented.

It could help with readability and consistency across the app, by the way. For example, the bright green (on a white background) used in the titles of the settings menu might not be the best color in terms of contrast/accessibility and using the system default would pick something the user is happy with. It would also fix the different types of green that are used for the different buttons, titles, options, etc. (Something that you may want to consider to improve even if you implement this as not everyone uses the latest Android version.)

There's also a new feature called "themed icons". I think it's part of the same theming/customisation features. I've never used it, but I think it's something worth implementing as otherwise the icon looks out of place with the other apps. This article has some screenshots/info about it: https://www.androidpolice.com/android-13-themed-icons-how-to-activate/