Don't export DEBIAN_FRONTEND, DEBCONF_NONINTERACTIVE_SEEN, etc. in brickstrap shell

ev3dev / brickstrap

Tool for bootstrapping Debian and creating bootable image files for embedded systems

MIT License

35 stars 26 forks source link

Don't export DEBIAN_FRONTEND, DEBCONF_NONINTERACTIVE_SEEN, etc. in brickstrap shell #25

Closed dlech closed 7 years ago

dlech commented 8 years ago

We are currently setting...

export DEBIAN_FRONTEND=noninteractive
export DEBCONF_NONINTERACTIVE_SEEN=true
export LC_ALL=C LANGUAGE=C LANG=C
export PATH=$PATH:/usr/local/sbin:/usr/sbin:/sbin

...globally these are needed for the configure-rootfs and run-hooks steps. It probably doesn't hurt for other steps, but it is not good to have these set for brickstrap shell.

cmacq2 commented 8 years ago

Worth noting: the PATH export may also be required for some other parts of brickstrap. We may be using tools from sbin paths already. A recent example is: /usr/sbin/update-binfmts (though I hardcoded that path). So the path export in particular needs careful review before moving it elsewhere.

It's also the case that we shell into the root account which may not have a valid rc file for the shell or sane .profile.

cmacq2 commented 8 years ago

Worth noting that in particular multistrap is also located in /usr/sbin.

dlech commented 7 years ago

no longer applicable