ev3dev / brickstrap

Tool for bootstrapping Debian and creating bootable image files for embedded systems
MIT License
35 stars 26 forks source link

Introduce a 'reports' directory #50

Closed cmacq2 closed 8 years ago

cmacq2 commented 8 years ago

Introduce a 'reports' directory to aggregate reports generated via custom-report.sh

With this change custom-report.sh instances will have a well-defined location to put their reports (example: $(br_report_dir)/your_report_name_here.txt), and brickstrap has a well-defined location to delete, namely $(br_report_dir) itself.

Introduce the br_output_basename function so reporting scripts have a well defined template basename for report file names.

cmacq2 commented 8 years ago

Any thoughts on this?

dlech commented 8 years ago

Looks good to me. I might be inclined to call the br_output_basename function br_image_basename instead.

cmacq2 commented 8 years ago

I thought of that but decided against it when I wrote the code because:

dlech commented 8 years ago

Isn't brp_image_name the full name (including file extension)? Also, since the "output" name can be specified with the -I option (advertised as image base name), I think it makes more sense to use br_image_basename unless you are planning on making it more generic by updating the docs and maybe changing the parameter to -o.

cmacq2 commented 8 years ago

Isn't brp_image_name the full name (including file extension)?

Correct.

I think it makes more sense to use br_image_basename

Updated the PR accordingly.