Check if /brickstrap/_tar-exclude exists in docker

ev3dev / brickstrap

Tool for bootstrapping Debian and creating bootable image files for embedded systems

MIT License

35 stars 26 forks source link

Check if /brickstrap/_tar-exclude exists in docker #61

Closed vladshablinsky closed 7 years ago

vladshablinsky commented 7 years ago

Brickstrap fails if we don't check that /brickstrap/_tar-exclude exists.

➜ viki:git$ ./brickstrap/brickstrap.sh create-tar b01ab378b678 OUTPUT.tar
Checking docker image tar version...
tar 1.27.1-2+b1
Creating OUTPUT.tar from b01ab378b678...
/bin/tar: /brickstrap/_tar-exclude: No such file or directory
/bin/tar: Error is not recoverable: exiting now

See #60.

dlech commented 7 years ago

Have you tested this to make sure it works?

Also, please indent using 4 spaces. Other than that, it looks good to me.

vladshablinsky commented 7 years ago

Have you tested this to make sure it works?

I tested it on a container with and without /brickstrap/_tar-exclude file and both of them finished with done.

Also, please indent using 4 spaces.

Sorry for that. I usually use two spaces and didn't noticed that four spaces are used here. Indentation seems fine now.

dlech commented 7 years ago

Excellent! Thank you very much.