Use built-in tar version command instead of dpkg

ev3dev / brickstrap

Tool for bootstrapping Debian and creating bootable image files for embedded systems

MIT License

35 stars 26 forks source link

Use built-in tar version command instead of dpkg #64

Closed hashworks closed 6 years ago

hashworks commented 6 years ago

Since dpkg isn't available on non-debian systems it's better to use the build in tar --version command to check the tar version. Comparisation happens with the version-sort feature from coreutils sort.

Things I have tested:

BRICKSTRAP_DOCKER_IMAGE_TAR_VERSION output
SORTED_VERSION output
Setting BRICKSTRAP_DOCKER_IMAGE_TAR_VERSION=1.27
Setting BRICKSTRAP_DOCKER_IMAGE_TAR_VERSION=1.28

hashworks commented 6 years ago

54216dd failed because I forgot tar version 1.27.1 (great show-off of CI tests btw). Commit f0fd65c fixed that. According to the offical download folder this is the last version before 1.28.

hashworks commented 6 years ago

Actually... yes. I don't know why I didn't do it like this right away.

dlech commented 6 years ago

Looks great. Thanks!