ev3dev / ev3dev-lang-python

Pure python bindings for ev3dev
MIT License
425 stars 144 forks source link

PyPi release failing on CI server #693

Closed WasabiFan closed 4 years ago

WasabiFan commented 4 years ago

https://travis-ci.org/ev3dev/ev3dev-lang-python/jobs/616502703#L452

It's getting a bad version number and as a result failing to publish. Unclear why; I'll try to take a look soon. The Debian package should be good-to-go though.

ddemidov commented 4 years ago

When I do git describe locally, I get ev3dev-stretch/2.0.0 instead of 2.0.0. This probably means that the 2.0.0 tag is not annotated (created without -a switch).

WasabiFan commented 4 years ago

I created it as an annotated tag (-a) when I originally tagged it; the message is visible on GitHub:

image

I think this is because I created the 2.0.0 tag before running the release script (which in turn uses gbp to create the stretch/2.0.0 debian release tag). I did it in this order because I realized that doing it in the other order would cause the version.py file in the published package to include the old version.

I should be able to modify git_version.py to filter out bad tags.

ddemidov commented 4 years ago

I think this is because I created the 2.0.0 tag before running the release script (which in turn uses gbp to create the stretch/2.0.0 debian release tag).

Yes, that should be the case:

git tag --sort taggerdate | tail -n 3
2.0.0beta5
2.0.0
ev3dev-stretch/2.0.0
WasabiFan commented 4 years ago

🎉 Fixed now: https://pypi.org/project/python-ev3dev2/#history