MoveDifferential: use gyro support for better accuracy (reverted this commit)

ev3dev / ev3dev-lang-python

Pure python bindings for ev3dev

MIT License

425 stars 144 forks source link

MoveDifferential: use gyro support for better accuracy (reverted this commit) #705

Closed dwalton76 closed 4 years ago

dwalton76 commented 4 years ago

Resolves #620
unify (as much as possible) the turn API for MoveTank and MoveDifferential. MoveTank recently got gryo support so we needed to cleanup the API between it and MoveDifferential.
removed all trailing whitespaces in various files

dwalton76 commented 4 years ago

Still some more work to go on this, I should be able to get to the other comments this weekend.

WasabiFan commented 4 years ago

I had been waiting to review this until I had more time... I still have some concerns which I'll comment on when I can work through it more thoroughly.

dwalton76 commented 4 years ago

My bad...I had resolved all of the comments so thought we were set. We can revert the commit or I can tackle the new comments via a new PR.

WasabiFan commented 4 years ago

In the same vein as we discussed in #707 and shown in #715, this PR makes breaking changes, and it will cause confusion. I think this should be reverted so we can fix the breaking changes.

dwalton76 commented 4 years ago

@WasabiFan ack let me revert this and open a new PR. My bad for jumping the gun on the commit.

dwalton76 commented 4 years ago

Reverted this commit and opened https://github.com/ev3dev/ev3dev-lang-python/pull/718