search

ev3dev / ev3dev-lang

(deprecated) language bindings for ev3dev sensors, motors, LEDs, etc.
GNU General Public License v2.0
56 stars 39 forks source link

[spec] Fix an issue with led groups on BrickPi #119

Closed ddemidov closed 8 years ago

ddemidov commented 8 years ago

I was updating C++ bindings and noticed that led instance names on BrickPi coincide with group names. This is not an issue for python since group names are capitalized there by convention. This is a problem for C++ though, where everything is lower case.

I'd like to rename group names on BrickPI:

'Blue One' -> 'One'
'Blue Two' -> 'Two'

This will affect other bindings, so waiting approval from @rhempel and @WasabiFan.

WasabiFan commented 8 years ago

Those changes look good to me; I'm still trying to figure out how I can define the per-platform LEDs, so no harm done.

ddemidov commented 8 years ago

So, do I change the led names to brickpiX? Does naming brickpi leds as brickpi1 and brickpi2 sound a bit redundant?

ddemidov commented 8 years ago

Sorry, pushed to the wrong repo (rolled that back already).