search

ev3dev / ev3dev-lang

(deprecated) language bindings for ev3dev sensors, motors, LEDs, etc.
GNU General Public License v2.0
56 stars 39 forks source link

https://github.com/jabrena/ev3dev-lang-java/issues/6 #134

Closed jabrena closed 8 years ago

jabrena commented 8 years ago

Hi, this is my first pull request about the files which the content is generated by Autogen.

The file file: EV3DevConstants.java will be used by other Java classes.

This pull request is related with this issue: https://github.com/jabrena/ev3dev-lang-java/issues/6

Cheers

Juan Antonio

rhempel commented 8 years ago

@jabrena - we're going to skip this PR for now. Kernel release is coming up and I want to get the new spec.json as the baseline. Your API generator will likely need some minor adjustments.

WasabiFan commented 8 years ago

To be clear, we are interested in the library -- but it'd be best for us to wait a bit so that we can get the main repo updated and ready for kernel changes. I'd expect that these changes could require some changes on your end as well as we update the spec (but nothing too major, code-wise).

rhempel commented 8 years ago

Yes, we are definitely interested in the C# binding - sorry if that was not clear.

jabrena commented 8 years ago

@rhempel Yes of course, when you release the new kernel, I will update the template development.

dlech commented 8 years ago

The kernel has been released. http://www.ev3dev.org/news/2015/12/15/Kernel-Release-Cycle-9/

jabrena commented 8 years ago

Fun this weekend!!

This week, i read some new issues about motors. I will continúe with testing. I will make some questions.

Cheer mates.

Juan Antonio

jabrena commented 8 years ago

Hi @dlech,

is the package available to upgrade in the brick to continue testing?

dlech commented 8 years ago

Yes. sudo apt-get update; sudo apt-get upgrade; sudo apt-get dist-upgrade.

WasabiFan commented 8 years ago

@jabrena We recently changed the structure of our repo to make it so that, aside from adding your language to the list of language comment formats, you don't have to modify the main repo to be able to add and autogen your code. See #142 for more information.

jabrena commented 8 years ago

@WasabiFan Oki

I am going to close this pull request and follow the notes from #142