search

ev3dev / ev3dev-lang

(deprecated) language bindings for ev3dev sensors, motors, LEDs, etc.
GNU General Public License v2.0
56 stars 39 forks source link

Some typo on the driver docs #174

Open mob41 opened 7 years ago

mob41 commented 7 years ago

Hi,

I found out some typo in the following document: http://www.ev3dev.org/docs/sensors/hitechnic-nxt-color-sensor/ , whereas vendor_id would be HiTechnic instead of HiTechnc.

I am not quite sure about it, but I think it is HiTechnic

Regards, mob41

ddemidov commented 7 years ago

HiTechnc is consistently used as a vendor_id throughout this file (it is used to generate the page you linked): https://github.com/ev3dev/lego-linux-drivers/blob/master/sensors/nxt_i2c_sensor_defs.c. So this could be the intended value.

ddemidov commented 7 years ago

Also, vendor_id is defined as char[NXT_I2C_ID_STR_LEN + 1], where NXT_I2C_ID_STR_LEN is 8. So HiTechnic simply does not fit into vendor_id

mob41 commented 7 years ago

Just a suggestion: Can this be told at the docs? So the users won't be confused with HiTechnc