search

ev3dev / ev3dev-lang

(deprecated) language bindings for ev3dev sensors, motors, LEDs, etc.
GNU General Public License v2.0
56 stars 39 forks source link

Add color constants for the ColorSensor #177

Closed ddemidov closed 7 years ago

ddemidov commented 7 years ago

This adds colors to Color Sensor class as a list of property values. The entries in the list have additional information of value/type (as opposed to other lists, where the property value was assumed to be equal to the property name).

See rhempel/ev3dev-lang-python#296 for motivation.

ddemidov commented 7 years ago

See rhempel/ev3dev-lang-python#303 for an example of autogen template implementation using the new info.

ensonic commented 7 years ago

X11 ships with an RGB.txt that defines a lot of colors :)

ddemidov commented 7 years ago

These are specific color values returned by color sensor in COL-COLOR mode though.

ddemidov commented 7 years ago

I'll push the fixes in a couple of hours.

WasabiFan commented 7 years ago

This is a common theme with me... stop reviewing things at 5:00 in the morning!

ddemidov commented 7 years ago

You could always move a couple of time zones to the east. Here is 8pm for example, much easier to do reviews :)