search

ev3dev / ev3dev-lang

(deprecated) language bindings for ev3dev sensors, motors, LEDs, etc.
GNU General Public License v2.0
56 stars 39 forks source link

Update C++ bindings for compatibility with the latest kernel #36

Closed ddemidov closed 9 years ago

ddemidov commented 9 years ago

The changes are:

/sys/class/msensor -> /sys/class/lego-sensor
name               -> driver_name
dp                 -> decimals

I am not sure if this is worth merging since feature/autogen-cpp is in progress. This is used as a base for python-ev3dev v0.0.2.

ddemidov commented 9 years ago

Btw, should I create pull requests for each version bump of a submodule (python in my case)?

WasabiFan commented 9 years ago

should I create pull requests for each version bump of a submodule (python in my case)?

It's your choice; you can open a PR if you want to or I can update it for you when you do a release. I usually pay close attention to my GitHub activity feed, so I might update it for you without a prompt, but post a comment in the future if I miss a release.

As for this PR, my guess is that @fdetro either has already implemented these changes (this will mostly be fixed by autogen) or it's on his to-do list. But I don't know for sure.

WasabiFan commented 9 years ago

I just updated your python submodule to the most recent commit on your master branch.

ddemidov commented 9 years ago

Thanks, I'll close this then. This should not affect users of the python module since they can just install binary package from PyPI.