fix: remove redundant updateTransform in SpineSystem - Githubissues

eva-engine / eva.js

Eva.js is a front-end game engine specifically for creating interactive game projects.

https://eva.js.org

MIT License

1.75k stars 108 forks source link

fix: remove redundant updateTransform in SpineSystem #198

Closed w2moon closed 2 years ago

w2moon commented 2 years ago

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

What is the current behavior? (You can also link to an open issue here)

Spine's updateTransform will be called twice in one frame.

What is the new behavior (if this is a feature change)?

Spine's updateTransform will only be called in container's children update.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information:

terrykingcha commented 2 years ago

When I debugger these codes, I didn't find that updateTransform would be called twice.