search

evacchi / firefox-custom-badge

Displays your profile id as a badge on the Firefox icon
6 stars 2 forks source link

Add ability to modify the text through preferences (Add-on Manager), and refactor code to use the Add-on SDK. #3

Closed jf closed 9 years ago

jf commented 9 years ago

Hi @evacchi , dunno if you're still going to stick with the text label idea, given the discussion in https://github.com/evacchi/firefox-custom-badge/issues/1, but... this finally adds the ability to edit the text through a preference system. Much easier than having to go to about:config, and then manually creating the string value or editing it yourself.

I realize this is a major rewrite (only 2 things have stayed the same - the require("chrome") line, and the (very appreciated) fact that the info about how to get at the dock is still there), so just let me know what you think. Thanks.

jf commented 9 years ago

Sorry - realized that the functionality wasnt totally complete as yet and fixed it.

Noitidart commented 9 years ago

Excellent work jf!

Noitidart commented 9 years ago

It is always so nice to see collaboration, one person makes something others improve it!

jf commented 9 years ago

Thanks, @Noitidart . Indeed, I'm very grateful to @evacchi for the work and for making it available and opensource....

jf commented 9 years ago

ping, @evacchi . Can you spare some time to take a look at this? It'll be a quick one.

evacchi commented 9 years ago

sorry man, I've been very busy lately. You have basically rewritten the whole thing, so it seems to me unfair to just merge your pull request. I'd say go ahead and make it your own :) I could link the readme to your repo; but if you really want me to I'll be happy to merge it

jf commented 9 years ago

Thanks, evacchi. If you're busy, I'd like to make it my own then. Can't say that there's anything more to do, but at least I'll be watching over it!

jf commented 9 years ago

hi, @evacchi, fyi the repo is now up at https://github.com/jf/fosx-label. I want to thank you, truly, for your work, and for showing that this was even possible in the first place! Without you, this would not have been possible....

evacchi commented 9 years ago

I have updated the readme to point to your new version! Nice job and keep it up!

jf commented 9 years ago

Thank you, evacchi! And again, thank you for everything that you've done!

Noitidart commented 9 years ago

@jf you should credit @evacchi in the readme of your repo and the AMO listing. This was purely driven by him. Even my work in Profilist was all due to him. I love your addon name very clever.

evacchi commented 8 years ago

I think jf did credit me enough, so that's ok :)

Noitidart commented 8 years ago

@jf you should merge my work from here to yours - https://addons.mozilla.org/en-US/firefox/addon/os-x-dock-icon-changer/?src=ss

It allows changing the dock icon too.