Add More Conditions to runif

evaera / Cmdr

Extensible command console for Roblox developers

https://eryn.io/Cmdr/

MIT License

363 stars 104 forks source link

Add More Conditions to runif #320

Open wilyt1 opened 9 months ago

wilyt1 commented 9 months ago

This pull request expands on the features mentioned in issue #25 by adding more conditions.

Declarations:

[x] I declare that this contribution was created in whole or in part by me.
[x] I declare that I have the right to submit this contribution under the terms of this repository's license and declarations.
[x] I understand and agree that this contribution and a record of it are public, maintained permanently, and may be redistributed under the terms of this repository's license.

autonordev commented 4 months ago

@wilyt1 have you considered the comments from krcnos?

wilyt1 commented 4 months ago

I've reviewed the feedback and explained why implementing those suggestions wouldn't work right now, mainly because of how the runif command is set up. You can check out the details here: link to the Discord conversation.