evaera / Cmdr

Extensible command console for Roblox developers
https://eryn.io/Cmdr/
MIT License
372 stars 108 forks source link

Replace window label string concatenation with interpolation #324

Closed itsrenderman closed 6 months ago

itsrenderman commented 6 months ago

More aesthetically pleasing and easier to read over the former concatenation

Declarations:

autonordev commented 6 months ago

Thanks for the pull-request. While it is more aesthetically pleasing to use interpolation, the Cmdr codebase is full of legacy code that works just fine (including concatenation and non-generalised iteration on dictionaries). Accordingly, commits which exclusively replace legacy with non-legacy features aren't ideal. If you're working on a contribution and see some related legacy code, changing it to modern features is OK though. 'Aesthetically pleasing' is itself not a very compelling reason to accept a change, even a plain simple one like this, given that the current legacy code is easily readable.