Add commands for Roblox Ban API

evaera / Cmdr

Extensible command console for Roblox developers

https://eryn.io/Cmdr/

MIT License

363 stars 104 forks source link

Add commands for Roblox Ban API #327

Open Flikter opened 2 months ago

Flikter commented 2 months ago

This pull request adds DefaultAdmin commands which allow usage of the new Roblox Ban API.

Declarations:

[x] I declare that this contribution was created in whole or in part by me.
[x] I declare that I have the right to submit this contribution under the terms of this repository's license and declarations.
[x] I understand and agree that this contribution and a record of it are public, maintained permanently, and may be redistributed under the terms of this repository's license.

autonordev commented 2 months ago

Thanks for the pr! I haven't managed to take a proper look at it yet, but I'm worried about the backwards incompatibility: I suspect many devs have commands named ban and unban. This is a larger issue tho and imo an ultimate limitation of the way we do default commands. @wilyt1 thoughts?

wilyt1 commented 2 months ago

If two commands are registered with the same name, the last one registered replaces the original. But since we can't predict if users register default or custom commands last, it could lead to unintended overwriting of custom commands by default ones.