search

evaera / RoVer

This repo is RoVer V1, which is now deprecated and will no longer work. Get Rover V2 now: https://rover.link
https://rover.link
Apache License 2.0
145 stars 201 forks source link

Support binds to Roblox Premium #222

Closed HypheX closed 4 years ago

HypheX commented 5 years ago

In the documentation, there is outdated information regarding Builder's Club.

image

Builder's Club as been phased out, and replaced with Premium. The documentation, and possibly the bot API should be updated to reflect these changes in ROBLOX.

PhoenixShay commented 5 years ago

We are waiting on Roblox to add an official endpoint for retrieving subscription type.

autonordev commented 5 years ago

We are waiting on Roblox to add an official endpoint for retrieving subscription type. This could in theory be done with this API endpoint.

That aside, BC has still not been 100% phased out. With things like badges and some static pages yet to be updated!

evaera commented 5 years ago

To clarify, the endpoint exists, but it requires authentication. I don't want to add any binds that require authentication because it makes them fragile. So we are waiting for Roblox to provide an unauthenticated alternative.

devSparkle commented 4 years ago

After testing a few users, I'm pretty sure you can discern if a user is a Premium member using this endpoint, and checking if membershipType > 0.

autonordev commented 4 years ago

The endpoint is unauthenticated, and by the looks premium is represented by 4. I can't find any BC users so can't confirm if BC has other terms, but I'm assuming that 1, 2, and 3 represent BC, TBC, and OBC.

devSparkle commented 4 years ago

That was my understanding of it too, @ElliottLMz. Nevertheless, to account for the users that are paying for a premium-like subscription but have yet to be upgraded to one, we should have the Virtual Group return true for anything above 0.

PhoenixShay commented 4 years ago

Whoops. Forgot to mention it should be fixed in 2e45881. The VirtualGroups are now Premium and NBC, and whois is now fixed as well. Docs need to be updated @evaera

evaera commented 4 years ago

gh-pages branch docs has docs the docs

autonordev commented 4 years ago

Opened PR #234 to update docs.

devSparkle commented 4 years ago

@PhoenixShay shouldn't we rename NBC? Context will be lost over time.

PhoenixShay commented 4 years ago

If you have a better name than “None”, by all means open a pull request. I just don’t want it to be confusing - keep in mind it’ll be a VirtualGroup too. Binding a role to “none” would be confusing.