search

evaera / RoVer

This repo is RoVer V1, which is now deprecated and will no longer work. Get Rover V2 now: https://rover.link
https://rover.link
Apache License 2.0
145 stars 201 forks source link

Fetch bot member in guild when .me is null #314

Closed Regalijan closed 3 years ago

Regalijan commented 3 years ago

Currently we've been seeing the verifiedrole command failing in some servers when .me is null, the notverifiedrole command was fixed as well in case that comes up.

Rythian2277 commented 3 years ago

After looking at the DiscordServer.js file, there is a function made which compares rank positions, could this be used for ease of updating in future? (I missed it within my own code aswell Fml)

Regalijan commented 3 years ago

Well yes, however it also checks for the bot's ability to manage roles (which may or may not be a good thing depending on how you view it)

Rythian2277 commented 3 years ago

It would prevent people from trying to bind when it doesn't have permission aswell, extra benefit

Regalijan commented 3 years ago

Yes, although we won't be able to communicate the specific error unless the checks are added elsewhere to determine what condition failed, but a general error might suffice