evaera / RoVer

This repo is RoVer V1, which is now deprecated and will no longer work. Get Rover V2 now: https://rover.link
https://rover.link
Apache License 2.0
145 stars 201 forks source link

DiscordMember double fetch? #341

Closed GoldenAngel2 closed 3 years ago

GoldenAngel2 commented 3 years ago

It looks like the bot double fetches the member information. https://github.com/evaera/RoVer/blob/master/src/DiscordMember.js#L164 and https://github.com/evaera/RoVer/blob/master/src/DiscordMember.js#L170

This just seems out of place and an oversight.

Also shouldn't you just use the force option for that, so it always fetches the new data?

Rythian2277 commented 3 years ago

This is an intended block of code. We may review it's functionality soon but at this time, it works as expected and we have not encountered any issues with this method.