search

evaera / matter

A modern ECS library for Roblox.
https://eryn.io/matter/
MIT License
143 stars 34 forks source link

Change `topoRunTime.useCurrentSystem` to return an explicit `nil` value #45

Closed ghost closed 1 year ago

Ukendio commented 1 year ago

Why do we need explicit returns of nil? Does StyLua require it or something?

Ukendio commented 1 year ago

If the idea is to make it more consistent with other parts off the codebase, take a look at the World.lua file (line- 441, 584 621, 772, ). If we are not too pedantic about it, nil and void/noop have very little differences in Luau unlike Javascript with (referring to the difference between undefined and void in ES3).

No, StyLua is a formatter, not a linter. Currently linters like Luau LSP don't mark for it since the method has no explicit return type.

Oh right, my mistake, I am not familiar with current Luau tooling. Well I think it furthers my point that this might not be necessary if we are not trying to actively silence existing linting errors such as (#27)