search

evaera / matter

A modern ECS library for Roblox.
https://eryn.io/matter/
MIT License
144 stars 34 forks source link

Make debugger widgets more compact #94

Open jackTabsCode opened 8 months ago

jackTabsCode commented 8 months ago

This is a heavily opinionated PR. I believe that Plasma's widgets and by extension, Matter's debugger widgets are a little too big. This PR makes them a bit more compact. It's not completely finished yet.

See https://github.com/evaera/plasma/pull/14, a related PR.

jackTabsCode commented 8 months ago

Before: image

After: image

Ukendio commented 8 months ago

I think this all looks better, but I would like to see more structural changes and that is more indicative of the UI needing a redesign in my opinion. The feeling as to why I feel like this is more bloated as opposed to something like imGUIs presets for UI is the size of padding, the style and such.

I might not have everyones vote of confidence in having an eye for design but I think Flecs have a great dashboard that feels compact and uniform image

jackTabsCode commented 8 months ago

Sure, I agree with you, but the PR is intended to make the widgets a little more usable. A full redesign is out of scope for this PR and is not something I have time for.

Ideally the APIs that the debugger can be made public at some point so that we can ship our own if we disagree.

jackTabsCode commented 8 months ago

Should also be noted that the reason this is a draft is because it's not finished. I haven't gotten to all of the widgets in Plasma yet

Ukendio commented 8 months ago

A full redesign is out of scope for this PR and is not something I have time for.

The way I see it is that if we plan to redesign it, all of this effort may go to waste. It is your decision whether you want to continue this though.

jackTabsCode commented 8 months ago

I am not aware of a project to fully redesign the debugger. What was discussed was to simply make it separable from Matter.

Regardless, these changes took less than 10 minutes.