search

evaera / roblox-lua-promise

Promise implementation for Roblox
https://eryn.io/roblox-lua-promise/
MIT License
275 stars 74 forks source link

feat: add and export Promise and PromiseLike types #69

Closed mastapegs closed 2 years ago

mastapegs commented 3 years ago

We've been using this library for handling Promises. We've also been using Luau to strongly type our Promises, so we wanted to see if we could merge the implementations of the Promise and PromiseLike types into the library.

evaera commented 3 years ago

Hi, thanks for the PR. Many people consume the promise library as a single file, so adding another file is something I think we should avoid.

It seems like the typings you submitted are only partially complete. If we are going to add Luau typings, we should strive to make sure all available functions have typings.

Another problem is that Luau typings don't work outside of Studio, which doesn't make them interesting to many developers. Until we get a way to externally verify Luau typings, adding them to the library makes it more difficult to maintain because it is difficult to validate the library still type checks. I think, for now, it might be best to leave type checking out from the library.

evaera commented 2 years ago

Closing as stale