search

eval-exec / super-hint.el

Add `which-function` as hint for `rg` & `xref` results.
GNU General Public License v3.0
15 stars 4 forks source link

Using minor modes instead of disable/enable functions #8

Closed krisbalintona closed 1 month ago

krisbalintona commented 1 month ago

Currently, super-hint has specific enable and disable functions to add/remove its functionality (i.e. super-hint-enable-rg, super-hint-disable-rg, super-hint-enable-xref, and super-hint-disable-xref). As far as conventions nowadays goes, wouldn't it be preferable to create globalized minor modes instead? E.g. a super-hint-xref-mode and super-hint-rg-mode. Effectively, users get the same control over what's enabled but without having to call a separate set of functions to enable versus disable. (Minor modes are also more discoverable for users.)

eval-exec commented 1 month ago

Great 👍

eval-exec commented 1 month ago

Are you interested in submitting a PR? :laughing:

krisbalintona commented 1 month ago

Are you interested in submitting a PR? :laughing:

Sure thing!

krisbalintona commented 1 month ago

Just submitted a PR. This should be good now.