changed html parser to nokogiri for better html5 support

eval / rack-pjax

pjax for rails and rack applications

http://rack-pjax.herokuapp.com/

MIT License

205 stars 65 forks source link

changed html parser to nokogiri for better html5 support #15

Closed yuszuv closed 12 years ago

yuszuv commented 12 years ago

As far as I understand the "/" in self-closing tags like and
isn't neccessary in html5. and because the
caused some serious trouble, i decided to replace hpricot by nokogiri which seems to have better html support.

btw. this is my first pull request. so is all i did formally correct?

mshibuya commented 12 years ago

+1 for migrating to nokogiri, now that hpricot have EOLed.

jdelStrother commented 12 years ago

Were you aware that rack-pjax used to be on Nokogiri, but switched to Hpricot? https://github.com/eval/rack-pjax/issues/4 Are the problems mentioned in that issue still present?

(FWIW, I'd also like to see rack-pjax switch back to Nokogiri)

gaaady commented 12 years ago

+1 for migrating to nokogiri

eval commented 12 years ago

Sorry for the non-responsiveness! :dolphin: :dolphin: Just released beta 0.6.0.beta that uses Nokogiri - any feedback welcome!

jdelStrother commented 12 years ago

Seems good to me.