Replace our signatures with Method::Signatures

evalEmpire / perl5i

A single module to fix as much of Perl 5 as possible in one go

http://search.cpan.org/perldoc?perl5i

Other

156 stars 42 forks source link

Replace our signatures with Method::Signatures #212

Open schwern opened 13 years ago

schwern commented 13 years ago

Method::Signatures has come a long way recently due to @barefootcoder's work. I'm happy enough with it that it doesn't seem worth the trouble to rewrite it in perl5i.

Before it can be introduced to perl5i, a few things need to be done.

The internal signature hash has to be turned into an introspectable object.
Devel::BeginLift must be removed (see https://github.com/schwern/method-signatures/issues/39)
Decide if method should happen at BEGIN time (https://github.com/schwern/method-signatures/issues/38)

Method::Signatures is a good choice. We already use Devel::Declare. If we're going to do stuff with OO, it's probably going to be with Mouse. Method::Signatures is 80% of a Mouse equivalent to MooseX::Declare.

rjattrill commented 12 years ago

What about Method::Signatures::Simple? My gripe with Method::Signatures is that is introduces a dependency on Devel::Declare which in turn won't compile with MSWin32 (Strawberry Perl 5.14.2).

schwern commented 12 years ago

Method::Signatures::Simple doesn't do much more than our existing one does, and it also depends on Devel::Declare.

Devel::Declare does work on Strawberry Perl, here's a pass result. http://www.cpantesters.org/cpan/report/c391477a-712d-1014-a7fc-683e36a472ca

If you're having problems, please report it to them as a bug. A lot of things depend on Devel::Declare. https://rt.cpan.org/Public/Dist/Display.html?Name=Devel-Declare

rjattrill commented 12 years ago

Thank you Michael.

I will check again why I can't get Method::Signatures installed.

Regards,

Ross.

On Mon, Jun 4, 2012 at 4:22 PM, Michael G. Schwern < reply@reply.github.com

wrote:

Method::Signatures::Simple doesn't do much more than our existing one does, and it also depends on Devel::Declare.

Devel::Declare does work on Strawberry Perl, here's a pass result. http://www.cpantesters.org/cpan/report/c391477a-712d-1014-a7fc-683e36a472ca

If you're having problems, please report it to them as a bug. A lot of things depend on Devel::Declare. https://rt.cpan.org/Public/Dist/Display.html?Name=Devel-Declare

Reply to this email directly or view it on GitHub: https://github.com/schwern/perl5i/issues/212#issuecomment-6093040