Applying a profile doesn't produce any changes

sheldonhull commented 3 years ago

System: macOS Extension Version: 1.0.6

I'm applying the settings and while it reloads the window, the desired extensions aren't enabled.

In my case I setup a profile with golang.go and some other Go tools. Select & Apply -> Window reloads -> viewing @installed go shows the extensions still greyed out.

Enabled dev tools, but nothing logged to the console that I can see. Not sure what else to check.

The extension seems super promising so thanks for your development effort on this!

sheldonhull commented 3 years ago

adding a mention here in case github notifications didn't come through. :-) @evald24

evald24 commented 3 years ago

Hi @sheldonhull, thanks.

Does this only happen when applied to a specific workspace or to others the same way?

I am now ill, when I feel better, I will immediately deal with this issue.

sheldonhull commented 3 years ago

No rush and feel better! Multiple workspaces I believe. I've tried on several projects and doesn't seem to apply the changes.

I just tried to test on my windows system, but despite setting up settings sync, it doesn't find any profiles. Is the extension profile settings being saved outside of the normal sync folders? Was hoping I could jump on codespaces, windows, or mac and select the desired extension set to toggle a new set of markdown writing extensions, Go extensions, Python extensions, and others.

evald24 commented 3 years ago

When a profile is applied, the selected extensions are added to the enabled ones, and not the selected ones to the disabled ones inside the workspace. On MacOS, the path to the workspace (folder) data is ~/Library/Application Support/Code/User/workspaceStorage/<uuid>/state.vscdb. The extensionsIdentifiers/disabled field stores information about the disabled extensions in this workspace, and theextensionsIdentifiers/enabled contains the enabled extensions for the workspace. This is how it works in vscode to enable/disable extensions, I made a wrapper over it.

*.vscdb is a SQLite file.

Lists are stored in ~/Library/Application Support/Code/User/globalStorage/state.vscdb in thevscodeExtensionProfiles/profiles field.

The list looks like this:

export type ProfileList = {
  [key: string]: ExtensionList;
};

export type ExtensionList = {
  [key: string]: {
    uuid: string;
    label?: string;
    description?: string;
  };
};

Example:

{
  "Example profile": {
    "zxh404.vscode-proto3": {
      "uuid": "1d3d1fb2-0d8f-47ed-bfce-990b8ddfc9d8",
      "label": "vscode-proto3",
      "description": "Protobuf 3 support for Visual Studio Code"
    },
    "dunstontc.vscode-go-syntax": {
      "uuid": "488eeb77-00fc-43a2-971f-bbc2db907ca2",
      "label": "vscode-go-syntax",
      "description": "Syntax highlighting for Go (WIP)"
    },
    "coolbear.systemd-unit-file": {
      "uuid": "fe20f03a-2abf-470a-ab23-d671ec38ce42",
      "label": "systemd-unit-file",
      "description": "Language support for systemd unit files"
    },
    "kangping.protobuf": {
      "uuid": "5228abae-ad60-4fc3-a1d5-23c5a778c51a",
      "label": "protobuf",
      "description": "protobuf"
    },
    "hangxingliu.vscode-nginx-conf-hint": {
      "uuid": "c3d3e8fb-c61d-4edf-8fb8-32298bc763f9",
      "label": "nginx.conf hint",
      "description": "nginx.conf syntax, hint and autocompletion"
    },
    "zainchen.json": {
      "uuid": "311c4d7f-e81f-47f8-9956-6a9919ddef43",
      "label": "json",
      "description": "Json for Visual Studio Code"
    }
  },
  "Other profile": {
    "zxh404.vscode-proto3": {
      "uuid": "1d3d1fb2-0d8f-47ed-bfce-990b8ddfc9d8",
      "label": "vscode-proto3",
      "description": "Protobuf 3 support for Visual Studio Code"
    },
    "dunstontc.vscode-go-syntax": {
      "uuid": "488eeb77-00fc-43a2-971f-bbc2db907ca2",
      "label": "vscode-go-syntax",
      "description": "Syntax highlighting for Go (WIP)"
    }
  }
}

Initially, I did the saving in the settings.json file, but the huge list of extensions in the settings does not look very practical. I will add profile export / import function soon.

I invite you to discuss these thoughts and suggestions in this issue: Do I need additional functionality?

evald24 commented 3 years ago

I will add profile export / import function soon.

If I feel better today, I'll take on adding new features and improving it.