search

evaleev / libint

Libint: high-performance library for computing Gaussian integrals in quantum mechanics
Other
218 stars 96 forks source link

clang-format.sh only works with shells supporting `[[ ]]` conditionals #310

Closed evaleev closed 6 months ago

evaleev commented 6 months ago 
          This syntax, `[[` and `]]`, is a bash-extension and thus the script does not work on Debian/Ubuntu, where `/bin/sh` is symlinked to `dash`.

A solution is to change the shebang to #!/bin/bash, or use [ and ].

_Originally posted by @e-kwsm in https://github.com/evaleev/libint/pull/284#discussion_r1414599001_

evaleev commented 6 months ago

Thanks, @e-kwsm ... Clearly I relied too much on AI in writing this :) ksh and zsh also support bash syntax, but since bash seems to be universally available hardwiring to bash seems reasonable to me.

evaleev commented 6 months ago

resolved via https://github.com/evaleev/libint/pull/311