Fix panic where struct contains embedded unexported struct

evalphobia / logrus_fluent

fluentd hooks for logrus

Apache License 2.0

45 stars 22 forks source link

Fix panic where struct contains embedded unexported struct #15

Closed zirkome closed 7 years ago

zirkome commented 7 years ago

The issue comes from the fact that unexported struct-typed embedded fields were not handled separately leading to a panic when using Interface() function because of an unexported field.

Fix #14

coveralls commented 7 years ago

Coverage decreased (-5.5%) to 81.5% when pulling 98ee26b726500ea41bdc3e558e5f89baba08d6d2 on kokaz:master into 92541fcfe55451eaf2811be04d38e001475c294f on evalphobia:master.

coveralls commented 7 years ago

Coverage increased (+1.04%) to 88.0% when pulling 9845bdde550daee6a5827f42f8e1aac1b9ef2fba on kokaz:master into 92541fcfe55451eaf2811be04d38e001475c294f on evalphobia:master.

coveralls commented 7 years ago

Coverage increased (+1.04%) to 88.0% when pulling d6dab98f91ac5b67226d290857050422d9bbe8ad on kokaz:master into 92541fcfe55451eaf2811be04d38e001475c294f on evalphobia:master.

jwolski2 commented 7 years ago

@evalphobia Can you take a look at this for @kokaz and I?

evalphobia commented 7 years ago

Thank you for fixing! 🍭

evalphobia commented 7 years ago

Note: https://github.com/evalphobia/logrus_fluent/releases/tag/v0.2.0