search

evalphobia / logrus_sentry

sentry hook for logrus
MIT License
194 stars 78 forks source link

A small bugfix to create valid stacktraces #28

Closed flimzy closed 7 years ago

flimzy commented 7 years ago

raven.NewStacktraceFrame() ignores frames for runtime.goexit, which lead to occasional null values in stack traces generated from github.com/pkg/errors stacktraces, which sentry doesn't like. This fixes the oversight.

evalphobia commented 7 years ago

@flimzy Thanks! This PR looks affect test result around below, so would you change it to fix?

https://github.com/evalphobia/logrus_sentry/blob/master/sentry_test.go#L267-L277

flimzy commented 7 years ago

Whoops! Sorry for the oversight. It's fixed now.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 82.698% when pulling 318c78f8db85d67d707f41fc0c723b4731b55007 on flimzy:fixstacktrace into d5bbafed86205dd68f7b284ac11810bea1473a9f on evalphobia:master.

evalphobia commented 7 years ago

Thank you for fixing!

Note: https://github.com/evalphobia/logrus_sentry/releases/tag/v0.2.9