search

evalphobia / logrus_sentry

sentry hook for logrus
MIT License
194 stars 78 forks source link

Fix ordering of stack traces taken from pkg/errors #32

Closed flimzy closed 7 years ago

flimzy commented 7 years ago

Please accept my apologies for the second bug in my original PR. We're all pretty new to sentry and logrus here on this project... :)

Sentry expects stack traces to be in reverse order from that generated by Go by default. This corrects the order.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 82.558% when pulling 12a736c1ad30cca3e152aa9d911454eae5459711 on flimzy:stackorder into 3d7f0590b8bf893d3423f355be8dea7078fb3371 on evalphobia:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 82.558% when pulling d424ce59d7fc82c380d132e3c5c55cd832d8e62d on flimzy:stackorder into 3d7f0590b8bf893d3423f355be8dea7078fb3371 on evalphobia:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 82.558% when pulling 68effc8fc7e668310065ddf2d31429784d09c8d3 on flimzy:stackorder into 3d7f0590b8bf893d3423f355be8dea7078fb3371 on evalphobia:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 82.558% when pulling 04c58bb6705e73f1516fe784fb0d4f14e8359a24 on flimzy:stackorder into 3d7f0590b8bf893d3423f355be8dea7078fb3371 on evalphobia:master.

evalphobia commented 7 years ago

Thanks! (and sorry for my lateness 😭 )